Skip to content

fixes in dev-2.0 #8272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: dev-2.0
Choose a base branch
from
Open

fixes in dev-2.0 #8272

wants to merge 14 commits into from
+93 −11

Conversation

@ayushman1210
Copy link

@ayushman1210 ayushman1210 commented Nov 18, 2025 •
edited
Loading

What was fixed:

  • Issue: Calling [min(Infinity, 3)]) or [max(3, -Infinity)] threw a friendly error in v2.0.4+
  • Root cause: The Zod schema for the [Number] type didn't accept [Infinity]or [-Infinity] values
  • Solution: Updated the schema to explicitly allow these special numeric values

@ayushman1210
Copy link
Author

ayushman1210 commented Nov 18, 2025

@perminder-17 please review this Pr
Allow Infinity/-Infinity as Number parameters so [min()]) / [max()]
don't throw validation errors
add unit tests update
Typography visual baselines to match current rendering

perminder-17
perminder-17 reviewed Nov 18, 2025
View reviewed changes
Copy link
Collaborator

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I don't understand the reason to add these tests. Currently out unit tests doesn't pass, you need to fix them as I mentioned on the previous comment. I also mentioned the way to make the tests pass. Please consider that.

@ksen0
Copy link
Member

ksen0 commented Nov 19, 2025

In addition to addressing @perminder-17 's comments, please ensure that your PRs clearly link to the related issue (with "Resolves ___" or "Fixes ___"). Thank you!

@ayushman1210
Copy link
Author

ayushman1210 commented Nov 19, 2025

hi @perminder-17 still the test cases fails please help me !!
thanks

@ayushman1210
Copy link
Author

ayushman1210 commented Nov 20, 2025

Screenshot 2025-11-20 193905 Hi @perminder-17 please see locally all the test pases but why it show error here at pull request please tell

@ayushman1210
Copy link
Author

ayushman1210 commented Nov 21, 2025

Hi! The workflow failure seems intermittent. Could you please re-run the CI for this PR?
If it fails again, I can investigate further with more logs.
Thanks! @davepagurek @perminder-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perminder-17 perminder-17 perminder-17 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushman1210 @ksen0 @perminder-17